-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate class com.google.protobuf.DescriptorProtos #5997
Comments
Hi @dpredovic, thank you for reaching. Firebase uses protolite that includes the protolite-well-known-types module. To resolve the issue, you have to exclude the app/build.gradle.kts
That said, I’ll go ahead and close this issue. Let me know if there’s any misunderstanding and/or we need to re-open the issue for further investigation. |
Excluding the library fixes the build error, but leads to missing class at runtime:
|
Apologies about that. Per checking, the issue occurs in version I tried using the Here’s my update dependencies:
Could you check if that works with you as well? |
The old protobuf version works, no problem. I already downgraded, but we need a better solution. |
Thank you for your confirmation. I'll notify our engineers about this issue and see what we can do here. In the meantime, I suggest using the version protobuf-javalite: 4.26.1. |
Hi @dpredovic thanks for raising this issue. TL;DR; The latest version of Here's the rundown of the problem.
We'll work on our end and release new versions of the affected SDKs that don't have this issue. In the meanwhile, the workaround is using an older version of I'll keep this issue open until the new versions are out. Thanks again! |
Any update on that one? I see the new protobuf 4.27.1 is there but the error seems to still be there |
We should be able to fix this issue by removing the "extra" types we provide, and updating our protobuf dependency to In the meantime, we'll leave this bug open until we get around to fixing this, and also so that folks can give their +1. |
For anyone wondering it looks like the recent CVE from this week does not affect 4.26.x thankfully so folks can stay on that until this issue is fixed. |
[READ] Step 1: Are you in the right place?
Issues filed here should be about bugs in the code in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:
with the firebase tag.
google group.
of the above categories, reach out to the personalized
Firebase support channel.
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
protolite-well-known-types:18.0.0 contains "com.google.protobuf.DescriptorProtos", the same class as protobuf-javalite:4.27.0, resulting in the CheckDuplicatesRunnable failing:
Duplicate class com.google.protobuf.DescriptorProtos found in modules protobuf-javalite-4.27.0.jar -> protobuf-javalite-4.27.0 (com.google.protobuf:protobuf-javalite:4.27.0) and protolite-well-known-types-18.0.0.aar -> protolite-well-known-types-18.0.0-runtime (com.google.firebase:protolite-well-known-types:18.0.0)
Steps to reproduce:
try building an app with libraries above
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Relevant Code:
The text was updated successfully, but these errors were encountered: