Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are we using different Nonull annotations in ConfigUpdateListener? #6134

Open
LeoAndo opened this issue Jul 29, 2024 · 2 comments
Open
Labels
api: remoteconfig type: question Further information is requested

Comments

@LeoAndo
Copy link

LeoAndo commented Jul 29, 2024

[REQUIRED] Step 2: Describe your environment

  • Android Studio version: Android Studio Koala | 2024.1.1 Patch 1 Build #AI-241.18034.62.2411.12071903, built on July 11, 2024

  • Firebase Component: firebase remote config

  • Component version: 22.0.0 BoM(33.1.1)

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

There are no problems in the application, but why are different Nonnull annotations used in com/google/firebase/remoteconfig/ConfigUpdateListener.java?

Shouldn't they be unified to one of them? (androidx.annotation.NonNull or javax.annotation.Nonnull)

Android Studio will suggest androidx.annotation.NonNull.

スクリーンショット 2024-07-30 6 38 38

Relevant Code:

スクリーンショット 2024-07-30 6 40 51
@google-oss-bot
Copy link
Contributor

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@lehcar09 lehcar09 added api: remoteconfig type: question Further information is requested and removed needs-triage labels Jul 30, 2024
@lehcar09
Copy link
Contributor

Hi @LeoAndo, thanks you for reaching out and raising this question. This could be due to historical reasons or inconsistencies in the codebase. Let me check this with our engineers. I’ll get back to you once I hear from them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: remoteconfig type: question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants