Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

157237503: InAppMessagingDisplayResources.bundle not included in framework #5663

Closed
laurenmarshallVS opened this issue May 21, 2020 · 18 comments
Assignees
Labels
api: inappmessaging Firebase In App Messaging Infrastructure

Comments

@laurenmarshallVS
Copy link

Step 1: Describe your environment

  • Xcode version: 11.3.1
  • Firebase SDK version: 6.24.0
  • Firebase Component: In-App Messaging
  • Component version: 0.20.0
  • Installation method: CocoaPods (1.9.1) and Rome (1.0.1)

Step 2: Describe the problem

When following the steps in the Rome setup instructions, then the bundle does not exist in Rome/FirebaseInAppMessaging.framework/InAppMessagingDisplayResources.bundle.
No bundle is created.

NOTE: If I use CocoaPods 1.6.2, then the bundle is created properly.

Steps to reproduce:

Run bundle exec pod install with the Podfile listed below. No bundle is created in the FirebaseInAppMessaging.framework. Without the bundle, the app is not able to use the framework.

Relevant Code:

Podfile

platform :ios, '10.0'
use_frameworks!
inhibit_all_warnings!

# ------------------------- COCOAPODS ROME PLUGIN -------------------------

plugin 'cocoapods-rome', {
    dsym: false,
    configuration: 'Release'
}

# ------------------------- CUSTOM PODS IMPORT -------------------------

def Firebase_pod(version)
    pod 'Firebase/Core', version
    pod 'Firebase/InAppMessaging', version
end

# ------------------------- TARGET -------------------------

target '{PROJECT_NAME}' do
  Firebase_pod('6.24.0')
end

Gemfile

gem 'cocoapods', '1.9.1'
gem 'cocoapods-rome', '1.0.1'
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@paulb777 paulb777 added Infrastructure api: inappmessaging Firebase In App Messaging and removed needs-triage labels May 21, 2020
@JasonAHeron JasonAHeron changed the title InAppMessagingDisplayResources.bundle not included in framework 157237503: InAppMessagingDisplayResources.bundle not included in framework May 21, 2020
@paulb777
Copy link
Member

@laurenmarshallVS Thanks for the report. We'll take a deeper look in the next week or two. In the meantime, a workaround would be installing InAppMessagingDisplayResources.bundle via one of the other Firebase installation methods and manually adding it to the Xcode project.

@paulb777
Copy link
Member

Please try adding the files in Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Resources to the Xcode project and target.

@google-oss-bot
Copy link

Hey @laurenmarshallVS. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

1 similar comment
@google-oss-bot
Copy link

Hey @laurenmarshallVS. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

@google-oss-bot
Copy link

Since there haven't been any recent updates here, I am going to close this issue.

@laurenmarshallVS if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.

@laurenmarshallVS
Copy link
Author

laurenmarshallVS commented Jun 5, 2020

@paulb777 What more information do you need? Manually adding the files doesn't solve the problem.

@paulb777
Copy link
Member

paulb777 commented Jun 5, 2020

@laurenmarshallVS Does adding the files in Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Resources to the Xcode project and target fix the build?

@laurenmarshallVS
Copy link
Author

It does not because it's looking for a bundle.

@laurenmarshallVS
Copy link
Author

Also, when I manually made my own bundle out of the resources, it would crash the app.

@paulb777
Copy link
Member

paulb777 commented Jun 5, 2020

OK thanks. I've reopened for investigation.

@christibbs christibbs self-assigned this Jun 8, 2020
@christibbs
Copy link
Contributor

Investigating... will follow up this week.

@christibbs
Copy link
Contributor

Still looking into this, @laurenmarshallVS. Personally I'm having other issues with Rome setup as well. I'll update the instructions after resolving this.

@paulb777
Copy link
Member

Is this still an issue? With the emphasis on adding Swift Package Manager support, we're not investing too much in atypical package managers like Rome.

@laurenmarshallVS
Copy link
Author

@paulb777 I haven't tried again since we decided to drop attempting to use FirebaseInAppMessaging in our application. It doesn't mean that it's still not a problem in general though. It would need to be fixed if you are supporting Rome, but if you are dropping support for Rome, then it wouldn't matter.

@paulb777
Copy link
Member

OK thanks. We'll leave this open for now, but at a low priority.

@yinzara
Copy link

yinzara commented Apr 17, 2021

This definitely still needs attention and I don't think is related to Rome as I'm not even using it.

I'm having this problem when using this with the cordova-plugin-firebase-inappmessaging@4.0.0 which is including Firebase/InAppMessaging ~> 7.0.0 pod.

There is also a corresponding bug in cordova-plugin-firebasex that seems identical (though I don't use that plugin):
dpa99c/cordova-plugin-firebasex#326

There is no known work around that I can find.

I've also opened this issue with that plugin:
chemerisuk/cordova-plugin-firebase-inappmessaging#15

PhaseScriptExecution [CP]\ Copy\ Pods\ Resources /Users/yinzara/Library/Developer/Xcode/DerivedData/1ST-grxrjkrkjhmnifeyevheojlmoinj/Build/Intermediates.noindex/ArchiveIntermediates/1ST/IntermediateBuildFilesPath/1ST.build/Debug-iphoneos/1ST.build/Script-79BB01CF8D01C621EE3F9B46.sh (in target '1ST' from project '1ST')
    cd /Users/yinzara/tsg/1st/client/1stbet-cordova/platforms/ios
    /bin/sh -c /Users/yinzara/Library/Developer/Xcode/DerivedData/1ST-grxrjkrkjhmnifeyevheojlmoinj/Build/Intermediates.noindex/ArchiveIntermediates/1ST/IntermediateBuildFilesPath/1ST.build/Debug-iphoneos/1ST.build/Script-79BB01CF8D01C621EE3F9B46.sh
error: Resource "/Users/yinzara/Library/Developer/Xcode/DerivedData/1ST-grxrjkrkjhmnifeyevheojlmoinj/Build/Intermediates.noindex/ArchiveIntermediates/1ST/BuildProductsPath/Debug-iphoneos/FirebaseInAppMessaging/InAppMessagingDisplayResources.bundle" not found. Run 'pod install' to update the copy resources script.

** ARCHIVE FAILED **


The following build commands failed:
        PhaseScriptExecution [CP]\ Copy\ Pods\ Resources /Users/yinzara/Library/Developer/Xcode/DerivedData/1ST-grxrjkrkjhmnifeyevheojlmoinj/Build/Intermediates.noindex/ArchiveIntermediates/1ST/IntermediateBuildFilesPath/1ST.build/Debug-iphoneos/1ST.build/Script-79BB01CF8D01C621EE3F9B46.sh
(1 failure)

@paulb777
Copy link
Member

Closing for staleness. Rome is not a priority for us.

@firebase firebase locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: inappmessaging Firebase In App Messaging Infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants