Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade clang-format to v18 #12483

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Upgrade clang-format to v18 #12483

merged 3 commits into from
Mar 7, 2024

Conversation

andrewheard
Copy link
Contributor

clang-format@17 is no longer available in Homebrew, upgraded to v18.

#no-changelog

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

2 other files:

git grep clang-format@
CONTRIBUTING.md:    brew install clang-format@17
README.md:brew install clang-format@17

@andrewheard
Copy link
Contributor Author

2 other files:

git grep clang-format@
CONTRIBUTING.md:    brew install clang-format@17
README.md:brew install clang-format@17

Thanks! Done.

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.17% (2800722) to 88.10% (67800f9) by -0.07%.

    FilenameBase (2800722)Merge (67800f9)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.14%98.82%+0.69%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/91kf4NkD2x.html

@andrewheard andrewheard merged commit 5797426 into main Mar 7, 2024
75 checks passed
@andrewheard andrewheard deleted the ah/clang-format-18 branch March 7, 2024 01:44
@firebase firebase locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants