Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle duplication modified/removed events in rxfire #1185

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

jamesdaniels
Copy link
Member

Duplicate emissions affect modified and removes as will as insertion. This is a a port of angularfire#1825.

Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davideast davideast merged commit d99c197 into master Sep 4, 2018
@davideast davideast deleted the rxfire_duplicates branch September 4, 2018 19:29
@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants