Fix rollouts:create to handle backend regionality & other fixes #7862

blidd-google · 2024-10-22T18:13:32Z

Fixes the following issues:

Prompts user to select a region if multiple regions contain a backend with the given backend ID; if --force flag is passed and region is ambiguous, the command fails
Lists branches with autocomplete when no branch or commit is specified
Removes confirmation prompt after branch or commit is specified
Fixes short form flags (-b for --git-branch, -g for --git-commit, -i removed)
Sends request to stable v1beta API instead of v1alpha

joehan

Concerned about the breaking flag changes

joehan · 2024-10-25T19:34:18Z

src/apphosting/backend.ts

+  }
+
+  location =
+    location || (await promptLocation(projectId, "Select a location to host your backend:\n"));


Do these commands support noninteractive use cases? If so, we should double check this code - it seems like it will prompt even in noninteractive mode if there is no location.

joehan · 2024-10-25T19:35:01Z

src/apphosting/backend.ts

+  const rootDir = await promptOnce({
+    name: "rootDir",
+    type: "input",
+    default: "/",


Should this default to . instead? / can easily be mistaken for an absolute path.

joehan · 2024-10-25T19:38:06Z

src/apphosting/backend.ts

+async function promptNewBackendId(
+  projectId: string,
+  location: string,
+  prompt: any,


Use a stronger type than any here

joehan · 2024-10-25T19:41:17Z

src/apphosting/backend.ts

+    try {
+      await apphosting.getBackend(projectId, location, backendId);
+    } catch (err: any) {
+      if (err.status === 404) {


Ingrid recently added type safe helpers for getting status or message from an error (

firebase-tools/src/error.ts

Line 63 in 1d4b580

export function getErrStatus(err: unknown, defaultStatus?: number): number {

) - this would be a good place to use them to silence these check warnings.

Applies throughout.

joehan · 2024-10-25T19:44:08Z

src/apphosting/backend.ts

@@ -0,0 +1,482 @@
+import * as clc from "colorette";


Optional - this files has a mix of prompting functions and API calling functions. In the past, I've see this lead to really large and unwieldy files. If you'd like to get ahead of that, consider splitting this into backendPrompts.ts and backend.ts

joehan · 2024-10-25T19:48:57Z

src/commands/apphosting-rollouts-create.ts

@@ -7,13 +7,12 @@ import { createRollout } from "../apphosting/rollout";

 export const command = new Command("apphosting:rollouts:create <backendId>")
  .description("create a rollout using a build for an App Hosting backend")
-  .option("-l, --location <location>", "specify the region of the backend", "us-central1")
-  .option("-i, --id <rolloutId>", "id of the rollout (defaults to autogenerating a random id)", "")
+  .option("-l, --location <location>", "specify the region of the backend", "-")


These flag changes are breaking changes, and ideally should be part of the next major version., unless App Hosting has a strong argument for allowing breaks in minor versions.

blidd-google · 2024-10-28T19:21:23Z

Concerned about the breaking flag changes

The apphosting:rollouts:create feature was added without announcement, so our team is okay with the risk of a breaking change in a minor CLI release given that the likelihood we actually break anybody is very low.

taeold

+1 for making this breaking change.

nolafs · 2024-11-23T14:22:10Z

I currently using version 13.27.0 and the manual rollout option is missing:

error: apphosting:rollouts:create is not a Firebase command

blidd-google added 2 commits October 22, 2024 14:10

lookup backends in other regions

14a90f8

fix bug bash bugs

3869b15

blidd-google changed the title ~~Fix rollouts:create to handle backend regionality~~ Fix rollouts:create to handle backend regionality & other fixes Oct 24, 2024

blidd-google and others added 6 commits October 24, 2024 15:39

add src/apphosting/index.ts back in

27c1610

Merge branch 'master' into bl-create-rollout-region-fix

17b9a61

export doSetup from index

22341cb

fix broken import

59217ca

changelog

de8849a

Merge branch 'master' into bl-create-rollout-region-fix

7516b50

blidd-google requested review from tonyjhuang, taeold and joehan and removed request for tonyjhuang and taeold October 24, 2024 20:29

joehan requested changes Oct 25, 2024

View reviewed changes

taeold approved these changes Oct 28, 2024

View reviewed changes

joehan approved these changes Oct 28, 2024

View reviewed changes

blidd-google and others added 2 commits October 29, 2024 11:25

switch to v1beta from v1alpha

e65114a

Merge branch 'master' into bl-create-rollout-region-fix

16505a7

blidd-google enabled auto-merge (squash) October 29, 2024 15:33

blidd-google merged commit ec55947 into master Oct 29, 2024
44 of 45 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix rollouts:create to handle backend regionality & other fixes #7862

Fix rollouts:create to handle backend regionality & other fixes #7862

blidd-google commented Oct 22, 2024 •

edited

Loading

joehan left a comment

joehan Oct 25, 2024

joehan Oct 25, 2024

joehan Oct 25, 2024

joehan Oct 25, 2024

joehan Oct 25, 2024

joehan Oct 25, 2024

blidd-google commented Oct 28, 2024

taeold left a comment

nolafs commented Nov 23, 2024 •

edited

Loading

Fix rollouts:create to handle backend regionality & other fixes #7862

Fix rollouts:create to handle backend regionality & other fixes #7862

Conversation

blidd-google commented Oct 22, 2024 • edited Loading

joehan left a comment

Choose a reason for hiding this comment

joehan Oct 25, 2024

Choose a reason for hiding this comment

joehan Oct 25, 2024

Choose a reason for hiding this comment

joehan Oct 25, 2024

Choose a reason for hiding this comment

joehan Oct 25, 2024

Choose a reason for hiding this comment

joehan Oct 25, 2024

Choose a reason for hiding this comment

joehan Oct 25, 2024

Choose a reason for hiding this comment

blidd-google commented Oct 28, 2024

taeold left a comment

Choose a reason for hiding this comment

nolafs commented Nov 23, 2024 • edited Loading

blidd-google commented Oct 22, 2024 •

edited

Loading

nolafs commented Nov 23, 2024 •

edited

Loading