Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add support for Windows via Firebase C++ desktop SDK #10496

Merged
merged 65 commits into from
May 4, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Feb 21, 2023

Description

This PR adds support for Windows to firebase_core using the C++ desktop SDK.
The current SDK version is downloaded and cached for the current application automatically so not extra setup is required by the user.

We use the Pigeon types to handle everything from C++ without having to create the Platform Channel ourselves.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title feat: integration of C++ desktop SDK feat(core): add support for Windows thanks to C++ desktop SDK Mar 21, 2023
@@ -0,0 +1,155 @@
// Copyright 2023, the Chromium project authors. Please see the AUTHORS file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main CPP file to review

# customers of the plugin.
cmake_minimum_required(VERSION 3.14)

set(FIREBASE_SDK_VERSION "10.5.0")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way to auto download the SDK

@Lyokone Lyokone marked this pull request as ready for review April 13, 2023 10:08
@Salakar Salakar changed the title feat(core): add support for Windows thanks to C++ desktop SDK feat(core): add support for Windows via Firebase C++ desktop SDK Apr 18, 2023
@Lyokone Lyokone merged commit c0b8ad5 into master May 4, 2023
@Lyokone Lyokone deleted the feat/cpp branch May 4, 2023 14:05
@firebase firebase locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants