Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_dynamic_links] Have OnLinkErrorException extend PlatformException #6

Closed
mehmetf opened this issue Aug 21, 2019 · 1 comment

Comments

@mehmetf
Copy link
Contributor

mehmetf commented Aug 21, 2019

Firebase dynamic links creates a new error object. This should extend PlatformException (it effectively carries the same signature) so that it can be thrown by the app if needed.

class OnLinkErrorException extends PlatformException {
  OnLinkErrorException._(String code, String message, dynamic details):
      super(code: code, message: message, details: details);
}
@mehmetf
Copy link
Contributor Author

mehmetf commented Aug 25, 2019

Fixed with #15

@mehmetf mehmetf closed this as completed Aug 25, 2019
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant