-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(messaging, apple): allow system to display button for in-app notification settings #13484
base: main
Are you sure you want to change the base?
feat(messaging, apple): allow system to display button for in-app notification settings #13484
Conversation
Hey 👋 Thanks a lot for the PR, and sorry for the late review, it looks really good. |
packages/firebase_messaging/firebase_messaging/example/lib/permissions.dart
Outdated
Show resolved
Hide resolved
Thank you Already submitted |
@Lyokone |
Hello @StanleyCocos, a lot of CI are currently red, you would need to apply proper formatting to your PR ( |
Thank you. |
@Lyokone |
@russellwheatley Could you please guide me? It seems that my request isn't getting approved due to CI issues. I'm unsure if any adjustments are still needed on my part. |
It seems like everyone is quite busy. However, I still hope to get some help. What I know is that there are CI issues, but I’m unsure how to resolve them. Can I get some guidance? I’m following up almost every day. |
@StanleyCocos - Sorry for the late response. This looks good to me. I've approved CI run, let's see what the result is 👍 |
@russellwheatley |
@StanleyCocos - I've just merged with main branch which ought to have a fix for CI. Nothing on your end to do now 🙏 |
Thank you. |
Description
I found that there is no option to set a button to display the app settings in the notification settings when registering for push notifications. I hope to add this feature.
resolves #13688
Specifically, the UNAuthorizationOptions.UNAuthorizationOptionProvidesAppNotificationSettings provided by iOS is missing.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?