Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip flakey subscribe to topic tests + sessionId() for iOS on CI #13689

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 5, 2024

Description

  • Tests consistently fail on iOS because APNS token isn't received before subscribeToTopic() is called. Skipped on CI.
  • analytics getSessionId() is flakey as well. Skipped on CI.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title test(messaging): skip subscribe to topic tests on CI test: skip flakey subscribe to topic tests + sessionId() for iOS on CI Nov 6, 2024
@Lyokone Lyokone merged commit cfe324d into main Nov 7, 2024
28 of 31 checks passed
@Lyokone Lyokone deleted the messaging-tests-ci branch November 7, 2024 07:52
@firebase firebase locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants