Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect invalid Base64 encoding in signature #103

Closed
wants to merge 1 commit into from

Conversation

psignoret
Copy link

Identifies invalid Base64 encoding (base64_decode return false if the input data is an invalid Base64 string), and throws an exception. Addresses #102.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@nezarfadle
Copy link

Hi all,,

Why this PR haven't merge yet !!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 2, 2016
@psignoret
Copy link
Author

Just checking in here if this PR can be reviewed, declined or merged.

@bshaffer
Copy link
Collaborator

@psignoret this looks good to me. Can you rebase this so we can run the tests again?

@bshaffer
Copy link
Collaborator

merged in #162

@bshaffer bshaffer closed this Jun 21, 2017
@psignoret psignoret deleted the invalid-b64-sig branch June 23, 2017 20:06
@psignoret
Copy link
Author

Thanks, @bshaffer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants