-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect invalid Base64 encoding in signature #103
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
8b12445
to
211203a
Compare
Hi all,, Why this PR haven't merge yet !! |
CLAs look good, thanks! |
Just checking in here if this PR can be reviewed, declined or merged. |
@psignoret this looks good to me. Can you rebase this so we can run the tests again? |
merged in #162 |
Thanks, @bshaffer ! |
Identifies invalid Base64 encoding (
base64_decode
returnfalse
if the input data is an invalid Base64 string), and throws an exception. Addresses #102.