Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move auto-generated code to separate crates #608

Closed
andreeaflorescu opened this issue Nov 19, 2018 · 1 comment
Closed

Move auto-generated code to separate crates #608

andreeaflorescu opened this issue Nov 19, 2018 · 1 comment
Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Milestone
ARM Support

Comments

@andreeaflorescu
Copy link
Member

Not all auto-generated files are in separate crates.

One example is the x86 crate which contains both auto-generated code and written code. We need to refactor crates like this to separate the auto-generated code from the rest of the code.
The auto-generated code is currently in crates with _sys suffix and the plan is to renamed them to ${name}_gen. Check issue: #602.

The auto-generated code is excluded from the code coverage report.
@andreeaflorescu andreeaflorescu added refactoring Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled labels Nov 19, 2018
@raduweiss raduweiss mentioned this issue Dec 10, 2018
Closed
8 tasks
@raduweiss raduweiss added this to the ARM Support milestone Feb 15, 2019
@dianpopa
Copy link
Contributor

The x86 crate does not exist anymore. All auto-generated code resides now inside crates that are named like *_gen. See #756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Projects
None yet
Milestone
ARM Support
Development

No branches or pull requests
3 participants
@andreeaflorescu @dianpopa @raduweiss