Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDS User Guide Equation 17.9 typo #12884

Closed
r-broek opened this issue May 6, 2024 · 2 comments
Closed

FDS User Guide Equation 17.9 typo #12884

r-broek opened this issue May 6, 2024 · 2 comments
Assignees

Comments

@r-broek
Copy link

r-broek commented May 6, 2024

Dear FDS developers,

If I am not mistaken, Equation 17.9 (User guide) should not contain the surface-to-volume ratio $\sigma$. The units do not match otherwise, and the LENGTH_SCALE is not used in line 3158 from wall.f90 either.

@mcgratta
Copy link
Contributor

mcgratta commented May 6, 2024

You may be right. $h_m$ has units of kg/s/m2 and $A_{\rm char}$ has units of kg/s/m3. $\sigma$ has units of 1/m. Or maybe $A_{\rm char}$ has some other units?

@ericvmueller
Copy link
Contributor

Yup it is a typo in the Guide. A_char and H_m have the same units. I will correct it - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants