Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scriptSig length for Lelantus transactions #1028

Closed
yura-pakhuchiy opened this issue May 6, 2021 · 4 comments
Closed

Reduce scriptSig length for Lelantus transactions #1028

yura-pakhuchiy opened this issue May 6, 2021 · 4 comments

Comments

@yura-pakhuchiy
Copy link

See trezor/trezor-firmware#1588
Long scriptSig prevents Trezor from signing transactions which uses Lelantus spends as inputs. However Trezor supports long transaction data if it placed after the transaction (similar to Firo coinbase transactions and Zcash privacy transactions). Firo can move Lelantus data from scriptSig to the end of transaction in the next hard fork. Without this change Trezor probably will remove Firo support.

@yura-pakhuchiy
Copy link
Author

@reubenyap @levonpetrosyan93 @nopslide consider implementing this ASAP to avoid removal of Trezor support

@reubenyap
Copy link
Member

Noted, we are looking into the issue and will discuss this at our upcoming dev meeting on the best way to resolve this.

@psolstice
Copy link
Contributor

As a solution we will move most of the data for lelantus mint/joinspits into transaction v3 payload field (CTransaction::vExtraPayload). This is a field introduced in DASH for proreg data and it should be compatible with hardware wallets. This will make scriptSig compatible with Trezor.

@reubenyap
Copy link
Member

This is resolved with #1063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants