Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fluent to minimize dependencies #359

Open
nelson137 opened this issue Mar 28, 2024 · 1 comment
Open

Upgrade fluent to minimize dependencies #359

nelson137 opened this issue Mar 28, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@nelson137
Copy link
Contributor

nelson137 commented Mar 28, 2024

Upgrade fluent once they release a new version with this change to upgrade self_cell. This will reduce the double dependency:

warning[duplicate]: found 2 duplicate entries for crate 'self_cell'
    ┌─ /Users/nelson/Projects/Forks/bones/Cargo.lock:417:1
    │
417 │ ╭ self_cell 0.10.3 registry+https://github.com/rust-lang/crates.io-index
418 │ │ self_cell 1.0.3 registry+https://github.com/rust-lang/crates.io-index
    │ ╰─────────────────────────────────────────────────────────────────────^ lock entries
    │
    = self_cell v0.10.3
      └── fluent-bundle v0.15.2
          └── fluent v0.15.0
              └── bones_framework v0.3.0
                  ├── bones_bevy_renderer v0.3.0
                  │   ├── demo_assets_minimal v0.3.0
                  │   ├── demo_features v0.3.0
                  │   ├── demo_hello_world v0.3.0
                  │   └── demo_scripting v0.3.0
                  ├── demo_assets_minimal v0.3.0 (*)
                  ├── demo_features v0.3.0 (*)
                  ├── demo_hello_world v0.3.0 (*)
                  └── demo_scripting v0.3.0 (*)
    = self_cell v1.0.3
      └── self_cell v0.10.3
          └── fluent-bundle v0.15.2
              └── fluent v0.15.0
                  └── bones_framework v0.3.0
                      ├── bones_bevy_renderer v0.3.0
                      │   ├── demo_assets_minimal v0.3.0
                      │   ├── demo_features v0.3.0
                      │   ├── demo_hello_world v0.3.0
                      │   └── demo_scripting v0.3.0
                      ├── demo_assets_minimal v0.3.0 (*)
                      ├── demo_features v0.3.0 (*)
                      ├── demo_hello_world v0.3.0 (*)
                      └── demo_scripting v0.3.0 (*)
@zicklag zicklag added the dependencies Pull requests that update a dependency file label Mar 29, 2024
@alerque
Copy link

alerque commented May 5, 2024

This change has been merged (via a different PR than you have linked, but the same change) and is not in Git master if you want to depend on that. It should be in the next fluent-fallback release, whatever number that ends up being (not the safe harbor one v0.7.1 that went out today, whatever is next).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants