Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vault tls by cert path #112

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Support vault tls by cert path #112

merged 2 commits into from
Dec 19, 2023

Conversation

meridsa
Copy link
Contributor

@meridsa meridsa commented Nov 7, 2023

Allows adding TLS support by setting the certificate path on your filesystem to the VAULT_CERT environment variable.

@fishi0x01
Copy link
Owner

Please excuse my late response and thank you for the contribution!
Can you force push one more time so the CI request is re-triggered? The request gets deleted after 30 days 🙈

@meridsa
Copy link
Contributor Author

meridsa commented Dec 19, 2023

Hi, what do you mean by force push? The PR looks open to me.

@fishi0x01
Copy link
Owner

The problem is that the CI cannot be triggered because I didnt ack within 30 days https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

I.e., I need a fresh commit to re-trigger it, else the tests wont run on that change.

e.g.,

git commit -a --amend
git push origin vault-tls-support --force-with-lease

@meridsa
Copy link
Contributor Author

meridsa commented Dec 19, 2023

There we go 🛩️ 😄

Copy link
Owner

@fishi0x01 fishi0x01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fishi0x01 fishi0x01 merged commit ec8e57e into fishi0x01:master Dec 19, 2023
2 checks passed
@meridsa meridsa deleted the vault-tls-support branch December 19, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants