Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.18.0 compatibility #26

Merged
merged 3 commits into from
Sep 4, 2020
Merged

0.18.0 compatibility #26

merged 3 commits into from
Sep 4, 2020

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Sep 3, 2020

Description & motivation

0.18.0 release

Checklist

  • I have verified that these changes work locally
  • n/a I have updated the README.md (if applicable)
  • n/a I have added tests & descriptions to my models (and macros if applicable)

@@ -1,3 +1,3 @@
packages:
- package: fishtown-analytics/dbt_utils
version: [">=0.4.0", "<0.6.0"]
Copy link
Contributor Author

@clrcrl clrcrl Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this would work with earlier versions, but would return deprecation warnings. I'd prefer to be tightly scoped here instead

Copy link
Contributor

@jtcohen6 jtcohen6 Sep 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! If we're upgrading a package to use functionality only available in dbt >= 0.18.0 (dispatch), I think we should also scope it to require utils >= 0.6.0.

If a package does not require net-new functionality, though (stitch_utils, segment, logging, redshift), I don't know that we need to raise the lower bounds + cut a minor version?

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,3 +1,3 @@
packages:
- package: fishtown-analytics/dbt_utils
version: [">=0.4.0", "<0.6.0"]
Copy link
Contributor

@jtcohen6 jtcohen6 Sep 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! If we're upgrading a package to use functionality only available in dbt >= 0.18.0 (dispatch), I think we should also scope it to require utils >= 0.6.0.

If a package does not require net-new functionality, though (stitch_utils, segment, logging, redshift), I don't know that we need to raise the lower bounds + cut a minor version?

@clrcrl clrcrl merged commit 3eb5413 into master Sep 4, 2020
@clrcrl clrcrl deleted the 0-18-0 branch September 4, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants