-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.18.0 compatibility #26
Conversation
@@ -1,3 +1,3 @@ | |||
packages: | |||
- package: fishtown-analytics/dbt_utils | |||
version: [">=0.4.0", "<0.6.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this would work with earlier versions, but would return deprecation warnings. I'd prefer to be tightly scoped here instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! If we're upgrading a package to use functionality only available in dbt >= 0.18.0 (dispatch
), I think we should also scope it to require utils >= 0.6.0.
If a package does not require net-new functionality, though (stitch_utils
, segment
, logging
, redshift
), I don't know that we need to raise the lower bounds + cut a minor version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,3 +1,3 @@ | |||
packages: | |||
- package: fishtown-analytics/dbt_utils | |||
version: [">=0.4.0", "<0.6.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! If we're upgrading a package to use functionality only available in dbt >= 0.18.0 (dispatch
), I think we should also scope it to require utils >= 0.6.0.
If a package does not require net-new functionality, though (stitch_utils
, segment
, logging
, redshift
), I don't know that we need to raise the lower bounds + cut a minor version?
Description & motivation
0.18.0 release
Checklist