fix node selection syntax to match logic in dbt-core #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic in
is_selected_node
to better match the implementation in dbt-core. I think I initially chose to set theret
value then return at the end of the implementation because i was using_.each()
initially? The logic here now matches that of dbt-core exactly -- if each "selector part" matches the corresponding FQN part, then that node is a match. TheGLOB
selector part was previously required, but now it is optional.Test it with:
closes #36