Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node selection syntax to match logic in dbt-core #38

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Jul 21, 2019

This PR changes the logic in is_selected_node to better match the implementation in dbt-core. I think I initially chose to set the ret value then return at the end of the implementation because i was using _.each() initially? The logic here now matches that of dbt-core exactly -- if each "selector part" matches the corresponding FQN part, then that node is a match. The GLOB selector part was previously required, but now it is optional.

Test it with:

staging.* == staging
marts.* == marts
marts.core.* == marts.core

closes #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize use of --models syntax across CLI + docs site
1 participant