-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dispatch-ify ALL THE MACROS! #312
dispatch-ify ALL THE MACROS! #312
Conversation
@jtcohen6 not sure what I've done here...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! I think this is the way to go.
You need to allow for passing kwargs
through the macro dispatcher. It's a bit tricky.
Removing myself as reviewer, as Jeremy has it covered :) |
integration_tests/tests/logger/assert_pretty_output_msg_is_string.sql
Outdated
Show resolved
Hide resolved
onto the next thing... I don't have a postgres target handy (but can get one running without too much trouble probably). @jtcohen6 any shoves in the right direction here? I haven't the slightest how the dispatch addition would make a test fail...
|
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the hard work here @swanderz @chaerinlee1! Truly a public service on behalf of all adapter plugin users
If my memory serves me correctly, we don't want to pass through the defaults twice. e.g. instead of:
We only want:
See #279 |
oh right, yes I see the difference now! |
let this comment stand in for what should have been marking my draft PR as ready for review! |
@jtcohen6 — I'm going to let you do the honors here (unless you'd prefer me to!) 0.6.4 seems imminent! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it!!
@swanderz Could you add a changelog entry (I think "under the hood"), and add yourself + @chaerinlee1 as contributors?
@@ -7,6 +7,7 @@ | |||
- Speed up CI via threads, workflows ([#315](https://github.com/fishtown-analytics/dbt-utils/pull/315), [#316](https://github.com/fishtown-analytics/dbt-utils/pull/316)) | |||
- Fix `equality` test when used with ephemeral models + explicit column set ([#321](https://github.com/fishtown-analytics/dbt-utils/pull/321)) | |||
- Fix `get_query_results_as_dict` integration test with consistent ordering ([#322](https://github.com/fishtown-analytics/dbt-utils/pull/322)) | |||
- All macros are now properly dispatched, making it possible for non-core adapters to implement a shim package for dbt-utils ([#312](https://github.com/fishtown-analytics/dbt-utils/pull/312)) Thanks [@chaerinlee1](https://github.com/chaerinlee1) and [@swanderz](https://github.com/swanderz) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comme ça?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merci !
This is a:
master
dev/
branchdev/
branchDescription & motivation
see #311
cc: @alittlesliceoftom
Checklist