Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create config aliases for pre-hook and post-hook #1124

Closed
drewbanin opened this issue Nov 14, 2018 · 0 comments
Closed

create config aliases for pre-hook and post-hook #1124

drewbanin opened this issue Nov 14, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Milestone

Comments

@drewbanin
Copy link
Contributor

Feature

Feature description

Pre-hooks and post-hooks can be specified in a config() block, but they require the use of a dictionary instead of a list of keyword arguments. Instead, dbt should support the specification of these hooks using pre_hook and post_hook aliases.

Before:

{{
  config({
    "post-hook" : "grant select on {{ this }} to db_reader"
  })
}}

After:

{{
  config(
    post_hook="grant select on {{ this }} to db_reader"
  )
}}

Who will this benefit?

This will be a quality of life improvement for many dbt users :)

@drewbanin drewbanin added enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! estimate: 2 labels Nov 14, 2018
@drewbanin drewbanin modified the milestones: Stephen Girard, Grace Kelly Nov 14, 2018
@beckjake beckjake self-assigned this Nov 21, 2018
beckjake added a commit that referenced this issue Nov 26, 2018
…aliases

add pre_hook/post_hook aliases to config (#1124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

No branches or pull requests

2 participants