Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach another log handler to log() in RPC server context #1309

Closed
cmcarthur opened this issue Feb 20, 2019 · 1 comment
Closed

Attach another log handler to log() in RPC server context #1309

cmcarthur opened this issue Feb 20, 2019 · 1 comment
Assignees
@drewbanin
Milestone
Wilt Chamberlain

Comments

@cmcarthur
Copy link
Member

When we compile or run SQL via the RPC server, any logs or warnings generated can be useful to the client. Those logs should be returned as a new key in the RPC response.

The following should not be part of the response:

  • Access logs + request / response logs

Everything else, just slap into the response
@cmcarthur cmcarthur added this to the Wilt Chamberlain milestone Feb 20, 2019
@beckjake beckjake mentioned this issue Mar 7, 2019
Merged
@beckjake
Copy link
Contributor

Fixed in #1341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewbanin drewbanin

Labels
None yet
Projects
None yet
Milestone
Wilt Chamberlain
Development

No branches or pull requests
3 participants
@beckjake @cmcarthur @drewbanin