Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for networkx 1.x #1577

Closed
beckjake opened this issue Jun 27, 2019 · 0 comments · Fixed by #1814
Closed

Drop support for networkx 1.x #1577

beckjake opened this issue Jun 27, 2019 · 0 comments · Fixed by #1814
Labels
dependencies Changes to the version of dbt dependencies
Milestone
Louisa May Alcott

Comments

@beckjake
Copy link
Contributor

Feature

Drop support for networkx <2

Feature description

Currently we have this comment: https://github.com/fishtown-analytics/dbt/blob/42fb12027c6ccec4f1cd5b71391d469dd191581c/core/dbt/linker.py#L213

Which indicates to me that we should probably just drop 1.x support entirely and use 2.x exclusively, with its fixed nx.algorithms.find_cycle implementation.

Also, I am pretty sure we have zero interest in supporting old networkx versions, which we inevitably will otherwise.

Who will this benefit?

dbt maintainers!
@beckjake beckjake added this to the Louisa May Alcott milestone Jun 27, 2019
@drewbanin drewbanin added the dependencies Changes to the version of dbt dependencies label Aug 27, 2019
@beckjake beckjake mentioned this issue Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Changes to the version of dbt dependencies
Projects
None yet
Milestone
Louisa May Alcott
Development

Successfully merging a pull request may close this issue.

Upgrade dependencies dbt-labs/dbt-core
2 participants
@beckjake @drewbanin