Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the RPC server, have the "status" method return the logs from the last compile #1703

Closed
beckjake opened this issue Aug 27, 2019 · 0 comments · Fixed by #1715
Closed

In the RPC server, have the "status" method return the logs from the last compile #1703

beckjake opened this issue Aug 27, 2019 · 0 comments · Fixed by #1715
Assignees
Labels
enhancement New feature or request rpc Issues related to dbt's RPC server

Comments

@beckjake
Copy link
Contributor

Describe the feature

In #1699, I added a feature where a SIGHUP causes the RPC server to recompile the manifest. Unfortunately, it just keeps shoving the logs to stdout/dbt.log. Instead/additionally (whichever is easier) it should make them available to the 'status' method under a 'logs' key.

Describe alternatives you've considered

We could just keep dumping them to the regular logger

Additional context

N/A

Who will this benefit?

RPC clients

@beckjake beckjake added the enhancement New feature or request label Aug 27, 2019
@beckjake beckjake self-assigned this Aug 27, 2019
@drewbanin drewbanin added the rpc Issues related to dbt's RPC server label Aug 27, 2019
@drewbanin drewbanin added this to the Louisa May Alcott milestone Aug 27, 2019
beckjake added a commit that referenced this issue Aug 30, 2019
…ctured-rpc-logging

Feature/logbook structured rpc logging (#1703, #1704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rpc Issues related to dbt's RPC server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants