Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove APIObject #1762

Closed
beckjake opened this issue Sep 17, 2019 · 0 comments · Fixed by #1780
Closed

Remove APIObject #1762

beckjake opened this issue Sep 17, 2019 · 0 comments · Fixed by #1780
Labels
enhancement New feature or request

Comments

@beckjake
Copy link
Contributor

Describe the feature

I want to remove the last user of APIObject (BaseRelation and its subclasses) before we release Louisa-May-Alcott, so we can have a clean break from APIObject to hologram.JsonSchemaMixin in this release.

Describe alternatives you've considered

Leave it in the code forever?

Additional context

I've ported everything else to use hologram.JsonSchemaMixin, but Relations are still using the old APIObject directly. BaseRelation itself is a complicated beast, and there are a lot of internal and external users of the api.Relation object out there and we want to preserve compatibility with them.

Who will this benefit?

  • Plugin developers, who won't need to learn both JSONSchema and hologram.
  • dbt developers, who won't need to think about manually creating json schemas anymore.
@beckjake beckjake added enhancement New feature or request triage labels Sep 17, 2019
@beckjake beckjake added this to the Louisa May Alcott milestone Sep 17, 2019
@drewbanin drewbanin removed the triage label Sep 25, 2019
beckjake added a commit that referenced this issue Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants