-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when trying to call list_schemas macro for BigQuery adapter #2413
Fix error when trying to call list_schemas macro for BigQuery adapter #2413
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Azhar Dewji.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Azhar Dewji.
|
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @azhard! I guess we don't call this as a macro very often.
Can you please add yourself as a contributor in CHANGELOG.md as well? I don't think the next release currently has one, so add a new contributors section like the ones in earlier releases and add yourself/this PR to it. That way we know to give you credit in the release notes.
Thanks @azhard! I've kicked off tests and once they pass, we'll merge this. |
resolves #2412
Description
Adds missing
database
parameter toadapter.list_schemas
macro that is called bybigquery__list_schemas
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.