Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If any v1 configs are present, global-level v2 var declarations do not work #2469

Closed
beckjake opened this issue May 19, 2020 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@beckjake
Copy link
Contributor

Describe the bug

If you have some v2 project configs with global-level var declarations, adding any project with a v1 config breaks them.

Steps To Reproduce

Create 3 projects:

  • two with v2 configs and global var declarations
  • one with a v1 config

Even if the third project never accesses any vars from the v2 configs and vice-versa, dbt will convert the v2 configs into v1 configs and lose the global level vars.

I have a few test cases to exercise this behavior that I'll add with the fix, but I think basically that this:

vars:
  my_var: 1000

should become (repeated for seeds/snapshots, too)

models:
  project_1:
    vars:
      my_var: 1000
  project_2:
    vars:
      my_var: 1000
...

Which can then be overridden with any actual existing per-project config members.

Expected behavior

dbt should include make any global v2 vars available as a project-level config for each dependency and the root project.

System information

Any databases, any OS, any supported python, dbt==0.17.0rc1

@beckjake beckjake added bug Something isn't working triage labels May 19, 2020
@drewbanin drewbanin removed the triage label May 19, 2020
@drewbanin drewbanin added this to the Octavius Catto milestone May 19, 2020
@beckjake beckjake self-assigned this May 20, 2020
@drewbanin
Copy link
Contributor

closed by #2477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants