Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move starter project for init task into dbt repo #3005

Closed
jtcohen6 opened this issue Jan 11, 2021 · 3 comments
Closed

Move starter project for init task into dbt repo #3005

jtcohen6 opened this issue Jan 11, 2021 · 3 comments
Assignees
Labels
1.0.0 Issues related to the 1.0.0 release of dbt enhancement New feature or request init Issues related to initializing the dbt starter project
Milestone

Comments

@jtcohen6
Copy link
Contributor

Rather than storing the starter project cloned by dbt init in a separate repository (dbt-starter-project), we should store that code directly in the main dbt repo.

Originally, we stored the starter project separately so that we could make changes to it more frequently than we could cut new releases of dbt. Instead, over the past four years, we've cut many more releases to dbt than we have merged updates to the starter project :)

This helps us avoid annoying behavior when a specific dbt version requires a specific breaking change to the starter project (e.g. dbt-labs/dbt-starter-project#8, dbt-labs/dbt-starter-project#10).

We could take one of two implementation approaches:

  1. Store starter project files in the https://github.com/fishtown-analytics/dbt repository, dbt init works more or less the same by cloning from the repo @ the tag of the current dbt version
  2. Ship starter project files within each version of dbt, rewrite dbt init to just copy files (no cloning from remote)

Questions

Describe alternatives you've considered

  • Continue maintaining separate repo with starter project. Develop more rigorous plan for versions + tags.
@jtcohen6 jtcohen6 added the enhancement New feature or request label Jan 11, 2021
@jtcohen6 jtcohen6 added the init Issues related to initializing the dbt starter project label Jan 28, 2021
@jtcohen6 jtcohen6 added this to the Margaret Mead milestone Feb 10, 2021
@jtcohen6 jtcohen6 removed this from the Margaret Mead milestone May 3, 2021
@jtcohen6 jtcohen6 added this to the Oh-Twenty-One milestone May 12, 2021
@jtcohen6 jtcohen6 added the 1.0.0 Issues related to the 1.0.0 release of dbt label May 16, 2021
@leahwicz
Copy link
Contributor

  • IDE does not use the init command
    • Check what their init command does vs what we do
    • Why are they doing that?

@leahwicz leahwicz self-assigned this Jun 10, 2021
leahwicz added a commit that referenced this issue Jun 22, 2021
@ssassi
Copy link

ssassi commented Jun 23, 2021

Have you considered using https://github.com/cookiecutter/cookiecutter?

@jtcohen6
Copy link
Contributor Author

@ssassi Yes, we were just talking about it over in #3474 (which was just merged, and really closed this issue). I think there's a lot cookiecutter could get us. It's one step beyond what dbt init needs to do today, but if/as we add more complexity, we may decide it's worth the switch.

iknox-fa pushed a commit that referenced this issue Feb 8, 2022
Addresses issue #3005

automatic commit by git-black, original commits:
  c794600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 Issues related to the 1.0.0 release of dbt enhancement New feature or request init Issues related to initializing the dbt starter project
Projects
None yet
Development

No branches or pull requests

3 participants