Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3057 Moving from 'master' to 'HEAD' default branch in git #3104

Merged
merged 5 commits into from
Feb 18, 2021
Merged

3057 Moving from 'master' to 'HEAD' default branch in git #3104

merged 5 commits into from
Feb 18, 2021

Conversation

VasiliiSurov
Copy link
Contributor

resolves #3057

Description

Moving from 'master' to 'HEAD' default branch in git

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Feb 15, 2021
@VasiliiSurov VasiliiSurov marked this pull request as ready for review February 15, 2021 22:07
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. I tested with:

packages:
  - git: https://github.com/fishtown-analytics/dbt-codegen   # 'master' branch default
  - git: https://github.com/tailsdotcom/dbt_artifacts        # 'main' branch default
  - git: https://gitlab.com/gitlab-data/snowflake_spend      # 'master' branch default

And:

$ dbt deps
Running with dbt=0.19.0
WARNING: The git package "https://github.com/fishtown-analytics/dbt-codegen" is not pinned.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://github.com/tailsdotcom/dbt_artifacts" is not pinned.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://gitlab.com/gitlab-data/snowflake_spend" is not pinned.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://github.com/fishtown-analytics/dbt-codegen" is not pinned.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://github.com/tailsdotcom/dbt_artifacts" is not pinned.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://gitlab.com/gitlab-data/snowflake_spend" is not pinned.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
Installing https://github.com/fishtown-analytics/dbt-codegen@HEAD
  Installed from revision HEAD

Installing https://github.com/tailsdotcom/dbt_artifacts@HEAD
  Installed from revision HEAD

Installing https://gitlab.com/gitlab-data/snowflake_spend@HEAD
  Installed from revision HEAD

Installing fishtown-analytics/dbt_utils@0.6.4
  Installed from version 0.6.4

Thanks for this @VasiliiSurov!

@jtcohen6 jtcohen6 merged commit 49b8693 into dbt-labs:develop Feb 18, 2021
@clrcrl
Copy link
Contributor

clrcrl commented Feb 18, 2021

@jtcohen6 , can you also test with:

packages:
  - git: https://github.com/fishtown-analytics/dbt-codegen 
    branch: master
  - git: https://github.com/tailsdotcom/dbt_artifacts   
    branch: main

I think those should give the same warning

@jtcohen6
Copy link
Contributor

@clrcrl Good call! Even if the user specifies the default branch, we should raise this error. They have recourse to disable via warn-unpinned. I'll open a follow-on PR and tag you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt deps does not handle non-master default branch
3 participants