-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3057 Moving from 'master' to 'HEAD' default branch in git #3104
Conversation
3057 Replacing 'master' to 'HEAD' for default git commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm. I tested with:
packages:
- git: https://github.com/fishtown-analytics/dbt-codegen # 'master' branch default
- git: https://github.com/tailsdotcom/dbt_artifacts # 'main' branch default
- git: https://gitlab.com/gitlab-data/snowflake_spend # 'master' branch default
And:
$ dbt deps
Running with dbt=0.19.0
WARNING: The git package "https://github.com/fishtown-analytics/dbt-codegen" is not pinned.
This can introduce breaking changes into your project without warning!
See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://github.com/tailsdotcom/dbt_artifacts" is not pinned.
This can introduce breaking changes into your project without warning!
See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://gitlab.com/gitlab-data/snowflake_spend" is not pinned.
This can introduce breaking changes into your project without warning!
See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://github.com/fishtown-analytics/dbt-codegen" is not pinned.
This can introduce breaking changes into your project without warning!
See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://github.com/tailsdotcom/dbt_artifacts" is not pinned.
This can introduce breaking changes into your project without warning!
See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://gitlab.com/gitlab-data/snowflake_spend" is not pinned.
This can introduce breaking changes into your project without warning!
See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
Installing https://github.com/fishtown-analytics/dbt-codegen@HEAD
Installed from revision HEAD
Installing https://github.com/tailsdotcom/dbt_artifacts@HEAD
Installed from revision HEAD
Installing https://gitlab.com/gitlab-data/snowflake_spend@HEAD
Installed from revision HEAD
Installing fishtown-analytics/dbt_utils@0.6.4
Installed from version 0.6.4
Thanks for this @VasiliiSurov!
@jtcohen6 , can you also test with:
I think those should give the same warning |
@clrcrl Good call! Even if the user specifies the default branch, we should raise this error. They have recourse to disable via |
resolves #3057
Description
Moving from 'master' to 'HEAD' default branch in git
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.