git package: warn if specified revision master, main #3117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #3057, #3104
Previously, if a git package was unpinned, dbt tried to install it from
master
(hard coded). In #3104, this was fixed to usedHEAD
(default branch, regardless of name) and continue to warn if unpinned.We'd like to warn as well if the user specifies the package
revision
as'master'
or'main'
, since either almost certainly represents the default branch. Users can disable the warning withwarn-unpinned: false
.Example
$ dbt deps
$ dbt deps
Checklist
This PR includes tests, or tests are not required/relevant for this PRCHANGELOG.md
and added information about my change to the "dbt next" section.