Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models that are disabled still fail compilation if they are missing vars #434

Closed
jthandy opened this issue May 17, 2017 · 2 comments · Fixed by #1429
Closed

Models that are disabled still fail compilation if they are missing vars #434

jthandy opened this issue May 17, 2017 · 2 comments · Fixed by #1429
Assignees
@beckjake
Labels
bug Something isn't working
Milestone
Wilt Chamberlain

Comments

@jthandy
Copy link
Member

jthandy commented May 17, 2017

To reproduce:

  1. create a model that requires a variable
  2. disable that model in dbt_project.yml
  3. do not supply the variable to the model

If models are disabled they shouldn't impact compilation in any way. Currently this is causing builds to fail to run that should succeed.
@drewbanin drewbanin added this to the Jinja Improvements milestone Mar 6, 2018
@drewbanin
Copy link
Contributor

I don't think this is true anymore. Will investigate

@drewbanin
Copy link
Contributor

^ this is still an issue

@drewbanin drewbanin added the bug Something isn't working label Apr 26, 2018
@drewbanin drewbanin removed this from the Jinja Improvements milestone Jun 28, 2018
@drewbanin drewbanin added this to the Wilt Chamberlain milestone Jan 23, 2019
@beckjake beckjake self-assigned this Apr 29, 2019
@beckjake beckjake mentioned this issue Apr 29, 2019
Merged
beckjake added a commit that referenced this issue Apr 30, 2019
@beckjake
Merge pull request #1429 from fishtown-analytics/fix/vars-in-disabled…
ad2f228 
…-models

Fix: missing vars in disabled models fail compilation (#434)
@jtcohen6 jtcohen6 mentioned this issue Nov 3, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beckjake beckjake

Labels
bug Something isn't working
Projects
None yet
Milestone
Wilt Chamberlain
Development

Successfully merging a pull request may close this issue.

Fix: missing vars in disabled models fail compilation (#434) dbt-labs/dbt-core
3 participants
@beckjake @drewbanin @jthandy