Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to dbt clean #1383

Closed
wants to merge 5 commits into from
Closed

Add logging to dbt clean #1383

wants to merge 5 commits into from

Conversation

emilieschario
Copy link
Contributor

This MR does two things:

  1. It adds some small updates to the contributing docs to make it easier for someone to get started without getting lost in the documentation of other tools.

  2. It adds logging to the dbt clean task as outlined in Feature: Command line output after dbt clean #1261.

A sample output on 0.13.0 might look like

(dbt36) >dbt clean
Running with dbt=0.13.0
Checking target/*
 Cleaned target/*
Checking dbt_modules/*
 Cleaned dbt_modules/*
Finished cleaning all paths.

@emilieschario emilieschario changed the title WIP: Add logging to dbt clean Add logging to dbt clean Mar 30, 2019
@emilieschario
Copy link
Contributor Author

@drewbanin I'd love to get your thoughts on this as is (or clarity on what else it needs).

@drewbanin drewbanin requested review from drewbanin and beckjake and removed request for drewbanin April 1, 2019 12:31
@beckjake
Copy link
Contributor

beckjake commented Apr 4, 2019

This looks good to me. Can you rebase off the existing fishtown-analytics:dev/wilt-chamberlain, or merge it in? #1378 in particular is the PR I'm interested in getting into your branch, so I can kick Windows tests off!

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for updating the contributing docs!

@emilieschario
Copy link
Contributor Author

@beckjake should be good to kickoff now!

@cmcarthur cmcarthur changed the base branch from dev/wilt-chamberlain to dev/0.13.1 April 8, 2019 14:23
@cmcarthur cmcarthur changed the base branch from dev/0.13.1 to dev/wilt-chamberlain April 8, 2019 14:29
@cmcarthur
Copy link
Member

@emilieschario I've reopened this PR with your commits against dev/0.13.1 over here: #1391. I'll merge that shortly. Thanks for contributing!!!

@cmcarthur cmcarthur closed this Apr 8, 2019
@emilieschario
Copy link
Contributor Author

Thanks @cmcarthur!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants