Fix: missing vars in disabled models fail compilation (#434) #1429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
When a var is missing during parsing, just always return
None
. Wait until runtime (compilation, etc) to actually fail about it.This avoids requiring a var to be set even when a model is disabled, but still fails as appropriate when a var isn't set for an enabled model at compile time.
I've based this on PR #1426 as they touch basically the same stuff.