flip around generate_alias_name args, add node to generate_schema_name args #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
fix/swap-alias-generator-args
branch
from
8598a50
to
68782b7
Compare
beckjake
changed the title
beckjake
force-pushed
the
fix/swap-alias-generator-args
branch
from
00559fd
to
1278662
Compare
drewbanin
commented
Jun 1, 2019
core/dbt/parser/base.py
Outdated
| ) | ||
| if too_many_args not in str(exc): | ||
| raise | ||
| msg = ('The generate_schema_name macro does not accept a second ' |
There was a problem hiding this comment.
Can you change this to
As of dbt v0.14.0, the `generate_schema_name` macro accepts a second "node" argument.
The one-argument form of `generate_schema_name` is deprecated, and will become
unsupported in a future release.
For more information, see: https://docs.getdbt.com/v0.14/docs/upgrading-to-014
What's the benefit of rolling this as a warning (with repeat=False) over using a new Deprecation class?
There was a problem hiding this comment.
Honestly, I had completely forgotten about the existence of deprecations somehow. I guess I haven't had to think about them in a while...
drewbanin
commented
Jun 3, 2019
There was a problem hiding this comment.
Super nitpicky feedback on the deprecation warning. It should read like:
Deprecation Warning: As of dbt v0.14.0, the `generate_schema_name` macro
accepts a second "node" argument. The one-argument form of `generate_schema_name`
is deprecated, and will become unsupported in a future release.
Merge once that's updated!
Fix many tests Support single-arg generate_schema_name macros Add repeat flag to warn_or_error to suppress duplicate warnings Add a warning if a user's macro does not take a second argument
beckjake
force-pushed
the
fix/swap-alias-generator-args
branch
from
5ee8858
to
28dc10e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
nodeargument to thegenerate_schema_namemacro, and makes thegenerate_alias_namemacro compatible with that change.Fixes #1483
Fixes #1463
It would be good to slip this in before people go out and build their own
generate_alias_namemacros!