Undefined name: import shutil for line 60 #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @cclauss - thanks for opening this PR! I believe we use Can you tell me more about why you've submitted this PR? |
|
That code currently throws a NameError because shutil is an undefined name in this context. Since that code is wrapped in a bare exception the NameError is silently swallowed which makes this block of code is a no-op. |
|
ha, yes! Very sorry - i thought you were removing this line, not adding it..... that should teach me to review PRs before I've finished my coffee 🤦♂ Sure, this LGTM, let's merge it :) |
drewbanin
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.