Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make is_incremental live up to its name #1608

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Make is_incremental live up to its name #1608

merged 1 commit into from
Jul 15, 2019
+12 −1

Conversation

drewbanin
Copy link
Contributor

closes #1249

Make is_incremental check if the specified materialization name is actually incremental. Before, this macro just checked that:

  1. the relation existed in the dbt
  2. it was of type table

The new logic is more strict, but also more sensible.

@drewbanin drewbanin requested a review from beckjake July 15, 2019 18:19
beckjake
beckjake approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have done this a long time ago! Looks great to me.

@drewbanin drewbanin mentioned this pull request Jul 15, 2019
Closed
@drewbanin drewbanin merged commit 5a1f0bd into dev/0.14.1 Jul 15, 2019
@drewbanin drewbanin deleted the fix/is-incremental-check-materialization branch July 15, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckjake beckjake beckjake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_incremental() macro should return false when the target relation is not "incremental"
2 participants
@drewbanin @beckjake