-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove APIObject (#1762) #1780
Remove APIObject (#1762) #1780
Conversation
5f743cb
to
3e95e43
Compare
406117f
to
da86314
Compare
Fix a lot of mypy things, add a number of adapter-ish modules to it Split relations and columns into separate files split context.common into base + common - base is all that's required for the config renderer Move Credentials into connection contracts since that's what they really are Removed model_name/table_name -> consolidated to identifier - I hope I did not break seeds, which claimed to care about render(False) Unify shared 'external' relation type with bigquery's own hack workarounds for some import cycles with plugin registration and config p arsing Assorted backwards compatibility fixes around types, deep_merge vs shallow merge Remove APIObject
da86314
to
eb9bfcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot going on here! It looks to me like table_name
can no longer be provided when creating a Relation object. That's fine, I'm glad to move on from that, but we should note it as a breaking change in the changelog!
When giving this a spin locally, I ran into an error indicating that typing_extensions
wasn't installed. I was able to work around it by installing this package. I'm using python 3.7.4 -- is that expected?
LGTM pending the questions above
I guess that should be expected, though it's really weird that the tests passed! |
add typing extensions module to setup.py Update changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it
Convert Relation types to use hologram.JsonSchemaMixin instead of APIObject, and remove it.
Fixes #1762
render(False)
but look like they're finearsing