-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/external source config #1784
Feature/external source config #1784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Something... "exciting" seems to have happened with your tests, so I've tried to kick them off again. If it doesn't work, you may have to close this PR and re-open them.
…/dbt into feature/external-source-config
@beckjake I think I got the testing situation sorted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @jtcohen6!! Let's
Adds external source table config. Related to #1318
Big idea: projects can assert metadata about an external table in the
sources
YML, including file location, column types, and partitions. They can then call macros that consume the metadata and perform DDL operations.Initial spec, macros, and more details in the
dbt-external-tables
packageTODO:
schema
cannot be set based ontarget
. Users may reasonably expect the ability to alter and test external table definitions in development schemas without interfering with the production external table.