Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/external source config #1784

Merged
merged 6 commits into from
Sep 27, 2019

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Sep 26, 2019

Adds external source table config. Related to #1318

Big idea: projects can assert metadata about an external table in the sources YML, including file location, column types, and partitions. They can then call macros that consume the metadata and perform DDL operations.

Initial spec, macros, and more details in the dbt-external-tables package

TODO:

  • Environments: Source schema cannot be set based on target. Users may reasonably expect the ability to alter and test external table definitions in development schemas without interfering with the production external table.

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Something... "exciting" seems to have happened with your tests, so I've tried to kick them off again. If it doesn't work, you may have to close this PR and re-open them.

@jtcohen6
Copy link
Contributor Author

@beckjake I think I got the testing situation sorted!

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jtcohen6!! Let's :shipit:

@drewbanin drewbanin added this to the Louisa May Alcott milestone Sep 27, 2019
@jtcohen6 jtcohen6 merged commit aceda5e into dev/louisa-may-alcott Sep 27, 2019
@jtcohen6 jtcohen6 deleted the feature/external-source-config branch September 27, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants