-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trailing comma when creating BQ options to each list item #1787
Add trailing comma when creating BQ options to each list item #1787
Conversation
- This is a bug in the existing code, BQ needs commas between option items. Discovered it when creating a temp table using dbt_utils
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @darrenhaken |
Thanks for the issue report and the quick PR @darrenhaken! This looks great :) I'm going to kick off the tests here - will merge it when they pass! @cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@drewbanin can you run the tests again? One failed but it doesn’t seem to be related |
oh - good catch. It's pretty unusual for the unit tests to fail like this... I just kicked off a rebuild :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great - let's ship it :)
Awesome! When do you think it will be released 🙂?
…On Tue, 1 Oct 2019 at 16:40, Drew Banin ***@***.***> wrote:
Merged #1787 <#1787> into
dev/louisa-may-alcott.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1787>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHIY644M2YSWQ5GEXQIG63QMNOMBANCNFSM4I3HJVAQ>
.
|
We should have an RC out in a couple of weeks - targeting an 0.15.0 release in November |
Great
…On Tue, 1 Oct 2019 at 17:13, Drew Banin ***@***.***> wrote:
We should have an RC out in a couple of weeks - targeting an 0.15.0
release in November
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1787>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHIY64X46W2VP7T2QWSIHLQMNSIBANCNFSM4I3HJVAQ>
.
|
Discovered it when creating a temp table using dbt_utils
This fixes #1786