Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing comma when creating BQ options to each list item #1787

Merged

Conversation

darrenhaken
Copy link
Contributor

  • This is a bug in the existing code, BQ needs commas between option items.
    Discovered it when creating a temp table using dbt_utils

This fixes #1786

- This is a bug in the existing code, BQ needs commas between option items.
Discovered it when creating a temp table using dbt_utils
@cla-bot
Copy link

cla-bot bot commented Sep 27, 2019

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @darrenhaken

@drewbanin
Copy link
Contributor

Thanks for the issue report and the quick PR @darrenhaken! This looks great :)

I'm going to kick off the tests here - will merge it when they pass!

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Sep 27, 2019
@cla-bot
Copy link

cla-bot bot commented Sep 27, 2019

The cla-bot has been summoned, and re-checked this pull request!

@darrenhaken
Copy link
Contributor Author

@drewbanin can you run the tests again? One failed but it doesn’t seem to be related

@drewbanin
Copy link
Contributor

oh - good catch. It's pretty unusual for the unit tests to fail like this... I just kicked off a rebuild :)

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great - let's ship it :)

@drewbanin drewbanin merged commit 5f30d5d into dbt-labs:dev/louisa-may-alcott Oct 1, 2019
@darrenhaken
Copy link
Contributor Author

darrenhaken commented Oct 1, 2019 via email

@drewbanin
Copy link
Contributor

We should have an RC out in a couple of weeks - targeting an 0.15.0 release in November

@darrenhaken
Copy link
Contributor Author

darrenhaken commented Oct 1, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to create BQ table when multiple Option items are added
2 participants