Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task tags parameter (#1822) #1828

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Conversation

beckjake
Copy link
Contributor

Fixes #1822

  • Created a base class for parameter types

    • include arbitrary "task_tags" parameter
    • include "timeout" so we can extract/document full/valid json schemas
  • Added output to ps and poll results (including errors)

  • Fixed a number of type annotation issues along the way

  • Refactored/moved some contracts that were scattered all over the place into contracts/rpc.py

  • Added an encoder for number.Real

    • this avoids an issue with values that can be floats or ints and are therefore valid under multiple encodings.

Create base class for parameter types
 - include arbitrary "task_tags" parameter
 - include "timeout" so we can extract/document full/valid json schemas
   - this includes some extra-fiddly behavior around numbers
Add output to ps and poll results (including errors)
Fix a number of type annotation issues along the way
@cla-bot cla-bot bot added the cla:yes label Oct 11, 2019
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some functional testing here and everything worked great!

I didn't spend so much time on the type annotation updates here. I can dig in further if that would be helpful, but if you feel confident in this as-is, then let's ship it!

@beckjake
Copy link
Contributor Author

I think since mypy passes, all is well on the type annotations front!

@beckjake beckjake merged commit 81b755f into dev/louisa-may-alcott Oct 11, 2019
@beckjake beckjake deleted the feature/task-tags branch October 11, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tags in RPC server tasks
2 participants