Fix quoting on columns for seeds/incremental models (#1847) #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
This looks great - ship it when the tests are in good shape.
Note: the change to the seed behavior is probably going to break some projects. On snowflake in particular, a csv with
| a | b | c |
|---|---|---|
| 1 | 2 | 3 |
Will be created as a table on Snowflake with columns named "a", "b", and "c". This new behavior is more correct and this is shipping for 0.15.0, so I feel ok about that fact. Let's be sure to document the change as a breaking one in the changelog.
Added tests Also fixed quoting on column expansions
beckjake
force-pushed
the
fix/column-quoting
branch
2 times, most recently
from
aa6fda7
to
21ebecd
Compare
beckjake
force-pushed
the
fix/column-quoting
branch
from
21ebecd
to
e0d4e93
Compare
|
I had to update a lot of tests to get this passing, but no actual code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1847
There are a few of fiddly places where this is an issue, expanding column types also hits it. Hopefully this is all of them.
Added tests accordingly.