Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add threads to commands (#1897) #1909

Merged
merged 1 commit into from
Nov 11, 2019
Merged

add threads to commands (#1897) #1909

merged 1 commit into from
Nov 11, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Nov 8, 2019

Fixes #1897

I added the --threads parameter to the RPC server's test, run, compile, and seed tasks as well because it was easy.

The tests assume the Concurrency: X threads log is accurate, so... don't break that.

add threads to commands
6ab537d 
Add tests accordingly
@cla-bot cla-bot bot added the cla:yes label Nov 8, 2019
drewbanin
drewbanin approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM 👍

@beckjake beckjake merged commit c26cf19 into dev/louisa-may-alcott Nov 11, 2019
@beckjake beckjake deleted the feature/honor-threads-flag branch November 11, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --threads in the cli_args rpc method
2 participants
@beckjake @drewbanin