-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle "meta:" key in schema/sources.yml #2015
Handle "meta:" key in schema/sources.yml #2015
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Taylor A. Murphy.
|
I just signed the CLA. @beckjake @drewbanin do I need to add anything to the tests for this? I saw several schema.yml files in the integration tests section but wasn't sure where this would best fit in. |
Thanks for opening this PR @tayloramurphy! (@cla-bot check) I just added a comment to the discussion on naming this field in the issue. Let me know what you think about that suggestion in the issue thread. I'll check out the code changes here. Kicking off the tests presently. |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Taylor A. Murphy.
|
The cla-bot has been summoned, and re-checked this pull request! |
I see the failing tests - will work on updating. |
@drewbanin pg integration tests are failing but it looks like it's on the install postgres step. I tried submitting another commit to see if it was a one-off but maybe there's something deeper? Please advise. |
@tayloramurphy this is definitely weird - I see:
It looks like it's related to an incident over here: https://status.chocolatey.org/ I'll kick off these tests again when it looks like things have been resolved w/ chocolatey |
I saw this happen for a few days in a row with another PR, but could not repro on my Windows box. It mysteriously went away after a time - I guess chocolatey is having some problems. |
/azp run |
I'll get back to this after the Christmas holiday! |
@drewbanin looks like postgres integration tests are passing but AFAICT the BQ, Snowflake, and Redshift integration tests are failing b/c it can't connect. Is this still related to the chocolately outage? https://status.chocolatey.org/issues/2019-12-18-timeouts-when-searching-and-installing-packages/ |
Yes! Tests are passing! @drewbanin or @beckjake officially submitting for review 😄 |
Thanks @tayloramurphy! I gave this a quick functional test and it looks really good to me :) I also just queued up this issue to render these eventual values in the docs site: dbt-labs/dbt-docs#66 Nice work with the tests here - I know that updating node contracts in the test suite can be a real slog! Adding @beckjake for code review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Just merged - thanks for your contribution to dbt @tayloramurphy :D |
Thank you both for the review! I'm pumped to get this feature in 😄 |
Closes #1362
This PR adds the ability for people to use the key
meta:
to add arbitrary information to their schema.yml and sources.yml files.I have tested locally by having this in my schema.yml
and in my sources.yaml
And was able to see in the manifest.json the data written appropriately. dbt also ran just fine.