Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial parsing with disabled models (#2055) #2056

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

beckjake
Copy link
Contributor

Fixes #2055

Fix an issue where partial parsing assumed model ids could not overlap between disabled and enabled models. Added a test.

@cla-bot cla-bot bot added the cla:yes label Jan 17, 2020
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- ship it!

@beckjake beckjake merged commit 66a4f76 into dev/0.15.2 Jan 19, 2020
@beckjake beckjake deleted the fix/partial-parsing-disabled-models branch January 19, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants