Feature: contexts cleanup #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
feature/contexts-redux
branch
from
982b59e to
fda0202
Compare
beckjake
force-pushed
the
feature/contexts-redux
branch
from
fda0202 to
889cf77
Compare
drewbanin
reviewed
Feb 4, 2020
| # project_profile_name is ignored, we just need it to appease mypy | ||
| # (Profile.from_args uses it) | ||
| # profile_name from the project | ||
| partial = Project.partial_load(os.getcwd()) |
There was a problem hiding this comment.
👀 do we want os.getcwd() here? Does running dbt from a subdir still work?
There was a problem hiding this comment.
Yeah. the relative directory handling stuff actually uses chdir to go up the file tree before this is ever called, so the current working directory is in fact fine here.
| ) | ||
|
|
||
| # get a new renderer using our target information and render the |
There was a problem hiding this comment.
this feels totally appropriate and sensible to me!
beckjake
force-pushed
the
feature/contexts-redux
branch
from
513bcfe to
987cbc2
Compare
added 2 commits
February 6, 2020 08:40
Rewrite/reorganize contexts
- now they are objects that have a to_dict()
- special decorators on properties/methods to indicate membership
- reorganize contexts/ to remove many many import cycles
Context behavior changes:
- 'dbt_version' is alwways available
- 'target' is available as long as the profile has been parsed
- 'project_name' is available in: query headers, hooks, models, and macro execution
Profiles/projects now render at load time
- reading a profile or project file requires a ConfigRenderer
- projects get an extra-fiddly special load for use during initial parsing
- it returns the profile name and a function that, given a renderer, can return the rest of the Project
- idea is: use the profile name to load the Profile, use that to build a ConfigRenderer that has a TargetContext, render the project with that
- profiles.yml is rendered with the 'base' context
- dbt_project.yml/schema.yml/packages.yml are rendered with the 'target' context: 'base' context + 'target'
- docs are rendered with the docs context: 'target' context + the 'doc' function
- query headers are rendered with the query header context: 'target' context + macros + 'project_name'
- executed macros/models should have the same context as previously (query headers + adapter/model/etc related functions)
Moved actual ref/source searching into the manifest
Moved the rest of the parse utils into parser/manifest.py
Made the ref/source resolvers defined in the provider context a bit more sane/well-defined
Picked consistent-but-not-great names for all the various context generation functions
Moved write_node into ParsedNode
Make slight tweaks to project initialization to support tests
beckjake
force-pushed
the
feature/contexts-redux
branch
from
987cbc2 to
148ef0d
Compare
|
Rebased to handle a merge conflict |
Fix comments Implement a TODO around duplicate macro names - added unit tests for it Implement a TODO around ref resolution
beckjake
force-pushed
the
feature/contexts-redux
branch
from
148ef0d to
2e5fdbf
Compare
|
Per slack discussion, merging this. |
mmeasic
added a commit
to mmeasic/docs.getdbt.com
that referenced
this pull request
Jan 17, 2021
The `project_name` is not available in the `dbt_project.yml` context. 'project_name' is available in: query headers, hooks, models, and macro execution See: dbt-labs/dbt-core#2085
3 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1503
Fix #1981 (you can still access it via
ref, but you really shouldn't)Fix #1255
Rewrite/reorganize contexts
to_dict()(but notdataclasses, and notJsonSchemaMixins)dbt.contextpackage to remove/avoid most import cyclesHigh-level context behavior changes:
Profiles/projects now render with more complete contexts
ConfigRenderer, which accepts a context dict as its argumentProfile, use that to build aConfigRendererthat has aTargetContext, render the project with thatprofiles.ymlis rendered with the 'base' contextdbt_project.yml/schema.yml/packages.ymlare rendered with the 'target' context: 'base' context + 'target'Moved actual ref/source searching into the manifest
Moved the rest of the parse utils into parser/manifest.py
Made the ref/source resolvers defined in the provider context a bit more sane/well-defined
Picked consistent-but-not-great names for all the various context generation functions
Moved write_node into ParsedNode
I had to thread the ConfigRenderer all through the deps code because way down in there, it wants to read projects for metadata reasons. I'm not sure what the best way to fix that is and I don't want to do it in this PR, but deps definitely shouldn't do that.
I'd like to write some net-new tests, but here is an initial pass that shouldn't break much of anything (though adding everything to the context may in fact do so).