Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create already-existing schemas (#2186) #2187

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Do not create already-existing schemas (#2186) #2187

merged 2 commits into from
Mar 11, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Mar 6, 2020

resolves #2186

Description

If a schema already exists and database quoting is enabled, actually skip creating that schema.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests~, or tests are not required/relevant for this PR~
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 6, 2020
@beckjake beckjake changed the title Do not create already-existing schemas Do not create already-existing schemas (#2186) Mar 6, 2020
@beckjake beckjake linked an issue Mar 6, 2020 that may be closed by this pull request
[Barbara Gittings]: Regression: dbt tries to create schemas that already exist #2186
Closed
@beckjake beckjake requested a review from drewbanin March 6, 2020 22:10
drewbanin
drewbanin approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but it looks like the tests need some attention!

@beckjake beckjake merged commit ad3b63e into dev/barbara-gittings Mar 11, 2020
@beckjake beckjake deleted the fix/no-creating-quoted-schemas branch March 11, 2020 04:00
@beckjake beckjake mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Barbara Gittings]: Regression: dbt tries to create schemas that already exist
2 participants
@beckjake @drewbanin