-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change redshift diststyle behavior #2298
Change redshift diststyle behavior #2298
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @rodrigodelmonte |
Thanks @rodrigodelmonte! This looks good to me -- i'll kick off the tests here :) @cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
957e6f5
to
d5f19de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code here LGTM!
One more quick change request though -- can you add yourself to the list of Contributors for this release in the CHANGELOG.md
file? We want to make sure you get credit for your contribution :D
Thanks!
d5f19de
to
2fe6fda
Compare
* Don't provide a diststyle to redshift tables when configured as "auto"
2fe6fda
to
ab07b8c
Compare
@drewbanin |
Alright alright, thanks @rodrigodelmonte! It looks like there's a changelog merge conflict - do you mind if I fix that up for you real quick? I'm happy for you to do it as well, lmk if you'd like a hand at all. Going to ship this as soon as that conflict is addressed! |
@drewbanin Let me know if it is fine now! |
This is great as-is. I'm going to merge it presently. Thanks for contributing to dbt! |
resolves #2246
Description
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.