Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python_requires to setup.py #2361

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Add python_requires to setup.py #2361

merged 1 commit into from
Apr 28, 2020

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 27, 2020 •
edited
Loading

This will let people know that they are running a too old version of Python. It requires 3.6.2+ because of the usage of the NoReturn hint: https://docs.python.org/3/library/typing.html#typing.NoReturn

resolves #2360

Description

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Apr 27, 2020
@beckjake
Copy link
Contributor

This looks good! Can you also add this to the other 5 setup.py files? Not everyone installs via pip install dbt and it'd be nice to help those people too.

  • plugins/*/setup.py
  • core/setup.py

@Fokko
Copy link
Contributor Author

Fokko commented Apr 27, 2020

Thanks for the quick reply @beckjake, I've updated the others as well

beckjake
beckjake approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I'll kick off the full tests shortly.

In the future we might want to set an upper bound here too - I bet 3.9 doesn't work, as we have some dependencies that trigger deprecation warnings on 3.8.

beckjake
beckjake reviewed Apr 27, 2020
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more thing! Can you please add yourself to the contributors link in the changelog? I don't think this needs an actual entry in the changelog but we do want to make sure we give you credit in the release notes!

@Fokko
Add python_requires to setup.py
8d84da4 
This will let people know that they are running
a too old version of Python

Signed-off-by: Fokko Driesprong <fokko@apache.org>
@Fokko
Copy link
Contributor Author

Fokko commented Apr 27, 2020

@beckjake Of course! I've added myself to the list, thanks!

@beckjake beckjake merged commit 4751a5f into dbt-labs:dev/octavius-catto Apr 28, 2020
@beckjake
Copy link
Contributor

Thanks for your contribution @Fokko! This will be in 0.17.0.

@Fokko Fokko deleted the patch-1 branch May 4, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckjake beckjake beckjake approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBT requires Python 3.6.2+
2 participants
@Fokko @beckjake