-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/improved graph selection #279
Conversation
This branch also fixes #266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drewbanin did you ever figure out why the tests were mysteriously passing when the code was actually broken?
This looks great. If we understand why the tests were incorrectly passing before, then
(Also, don't forget to add a line to the CHANGELOG)
dbt/compilation.py
Outdated
@@ -23,6 +23,8 @@ | |||
"models", "data tests", "schema tests", "archives", "analyses" | |||
] | |||
|
|||
GraphFile = 'graph.yml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicky but why not call this graph_file_name
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
test(('X', 'a'), ('b'), False) | ||
test(('X', 'a'), ('X', 'b'), False) | ||
test(('X', 'a'), ('X', 'a', 'b'), False) | ||
test(('X', 'a'), ('Y', '*'), False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOLY SHIT THESE ARE GREAT
@cmcarthur the typo in the
Now in the "update", we 1) insert into the correct table and 2) change the value of |
@cmcarthur great, going to add those changelog lines then merge later today |
cc @jthandy |
Remove errant default args from get_tables_by_pattern_sql
This works:
Models
Schema Testing
Custom Data Testing
Remaining Todo
this
package selector--models
to be take a space-separated string