Compile on-run-(start|end) hooks to file #412
Merged
+174
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
changed the title
cmcarthur
requested changes
May 9, 2017
There was a problem hiding this comment.
this looks pretty good. there is a lot of messy conditional logic in runner.py and compilation.py but you don't need to deal with that all here.
there are a few questions in here, wondering why you did a couple specific things in here.
if you fix the circle build, this is ok from my end
dbt/compilation.py
Outdated
| for name, node in flat_graph.get('nodes').items(): | ||
| self.link_node(linker, node, flat_graph) | ||
| linked_graph['nodes'][name] = node | ||
| for node_type in ['nodes', 'operations']: |
There was a problem hiding this comment.
curious why you put operations in a separate subgraph
There was a problem hiding this comment.
yeah, i think you're right -- these can in the nodes graph... let me investigate
| @@ -331,6 +331,52 @@ def load_and_parse_sql(package_name, root_project, all_projects, root_dir, | |||
| return parse_sql_nodes(result, root_project, all_projects, tags) | |||
There was a problem hiding this comment.
looks like this file was chmod +xed -- can you undo that
dbt/parser.py
Outdated
| 'raw_sql': hooks | ||
| }) | ||
|
|
||
| return parse_sql_nodes(result, root_project, all_projects, tags={hook_type}) |
| if is_model and is_ephemeral: | ||
| res.append(ancestor) | ||
|
|
||
| return set(res) |
dbt/runner.py
Outdated
| ] | ||
|
|
||
| return self.run_types_from_graph(include_spec, | ||
| exclude_spec, | ||
| resource_types=resource_types, | ||
| tags=set(), | ||
| should_run_hooks=False, | ||
| should_execute=False) | ||
| should_execute=False, | ||
| flatten_graph=True) |
There was a problem hiding this comment.
debugging! good catch
|
this fixes #403 |
cmcarthur
approved these changes
May 9, 2017
dbt/utils.py
Outdated
| @@ -31,6 +31,12 @@ class NodeType(object): | |||
| Operation = 'operation' | |||
|
|
|||
|
|
|||
| class RunHookTypes: | |||
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
compile on-run-(start|end) hooks to a file automatic commit by git-black, original commits: ce46052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cmcarthur i'm not super happy with this yet -- going to try to clean up a little in the AM