Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CTEs for schema tests #536

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Conversation

cmcarthur
Copy link
Member

for #528

reopened from #534

@cmcarthur
Copy link
Member Author

cc @ronnyli

@ronnyli
Copy link

ronnyli commented Sep 21, 2017

nice, it passed this time! I'm assuming circle checks if the changes work on big-query, redshift, postgres, and snowflake? I only personally tested on Postgres so far.

@cmcarthur
Copy link
Member Author

cmcarthur commented Sep 21, 2017

@ronnyli we have it set up to check postgres, bigquery and snowflake & drew played around with this.

thanks again for contributing! 🍺

this will go out with 0.9.0

@cmcarthur cmcarthur merged commit 6e52b52 into development Sep 21, 2017
@cmcarthur cmcarthur deleted the fix/remove-schema-test-CTEs branch September 21, 2017 21:03
@ronnyli
Copy link

ronnyli commented Sep 21, 2017

great! Thanks for your help

@drewbanin
Copy link
Contributor

great work @ronnyli :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants